Support pattern matching for Style/IdenticalConditionalBranches cop
#9855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR supports Ruby 2.7's pattern matching syntax for `Style/IdenticalConditionalBranches` cop. This `Style/IdenticalConditionalBranches` cop is detecting for `if` and` case`. Therefore, I think about detecting `case-match` with the cop instead of a new cop. It may also be suitable for the cop's role of detecting duplicated conditional branches.
koic
force-pushed
the
support_pattern_matching_for_style_identical_conditional_branches
branch
from
667bf4e
to
21a535d
Compare
|
Thanks! |
koic
deleted the
support_pattern_matching_for_style_identical_conditional_branches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports Ruby 2.7's pattern matching syntax for
Style/IdenticalConditionalBranchescop.This
Style/IdenticalConditionalBranchescop is detecting forifandcase.Therefore, I think about detecting
case-matchwith the cop instead of a new cop.It may also be suitable for the cop's role of detecting duplicated conditional branches.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.