Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 2.7's pattern matching for Layout/SpaceAroundKeyword #9841

Conversation

koic
Copy link
Member

@koic koic commented May 31, 2021

This PR supports guard if and unless syntax keywords of Ruby 2.7's pattern matching for Layout/SpaceAroundKeyword.

case 42
in 42 if true
  puts 'hello'
end

These nodes are called if-guard and unless-guard when using guard if and unless in pattern matching.

% ruby-parse example.rb
(case-match
  (int 42)
  (in-pattern
    (int 42)
    (if-guard
      (true))
    (send nil :puts
      (str "hello"))) nil)

See below for this guard semantics:
whitequark/parser#574 (comment)


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR supports guard `if` and `unless` syntax keywords of Ruby 2.7's
pattern matching for `Layout/SpaceAroundKeyword`.

```ruby
case 42
in 42 if true
  puts 'hello'
end
```

These nodes are called `if-guard` and `unless-guard` when using guard `if` and `unless`
in pattern matching.

```ruby
% ruby-parse example.rb
(case-match
  (int 42)
  (in-pattern
    (int 42)
    (if-guard
      (true))
    (send nil :puts
      (str "hello"))) nil)
```

See below for this guard semantics:
whitequark/parser#574 (comment)
@bbatsov bbatsov merged commit 40e9f30 into rubocop:master Jun 1, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 1, 2021

Thanks!

@koic koic deleted the support_pattern_matching_for_layout_space_around_keyword_cop branch June 1, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants