Add new Style/MultilineInPatternThen cop
#9834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_new_style_multiline_in_pattern_then_cop
branch
from
5cd885b
to
c0a4fbc
Compare
Follow rubocop/ruby-style-guide#873. This PR adds new `Style/MultilineInPatternThen` cop. It checks uses of the `then` keyword in multi-line `in` statement. ```ruby # bad case expression in pattern then end # good case expression in pattern end ``` This cop is similar to `Style/MultilineWhenThen` (and `Style/MultilineIfThen`) but with different supported syntax and Ruby version (requires 2.7 or higher).
koic
force-pushed
the
add_new_style_multiline_in_pattern_then_cop
branch
from
c0a4fbc
to
3bd037c
Compare
|
Thanks! |
koic
added a commit
that referenced
this pull request
Jun 5, 2021
I noticed this in the implementation of #9834.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rubocop/ruby-style-guide#873.
This PR adds new
Style/MultilineInPatternThencop.It checks uses of the
thenkeyword in multi-lineinstatement.This cop is similar to
Style/MultilineWhenThen(andStyle/MultilineIfThen) but with different supported syntax and Ruby version (requires 2.7 or higher).Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.