Add new Lint/EmptyInPattern cop
#9825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
commented
May 26, 2021
|
|
||
| def on_case_match(node) | ||
| node.in_pattern_branches.each do |branch| | ||
| next if branch.node_parts[-1] || cop_config['AllowComments'] && comment_lines?(node) |
There was a problem hiding this comment.
When rubocop/rubocop-ast#183 can be used, branch.node_parts[-1] can be updated to branch.body.
This PR adds new `Lint/EmptyInPattern` cop for Ruby 2.7's pattern matching. It checks for the presence of `in` branches without a body. ```ruby # bad case condition in [a] do_something in [a, b] end # good case condition in [a] do_something in [a, b] nil end # good - AllowComments: true (default) case condition in [a] do_something in [a, b] # noop end # bad - AllowComments: false case condition in [a] do_something in [a, b] # noop end ``` This cop is similar to `Lint/EmptyWhen`, but with different supported syntax and Ruby version (requires 2.7 or higher). And this PR use rubocop/rubocop-ast#183 feature, so it requires RuboCop AST 1.6.0 or higher.
koic
force-pushed
the
add_new_lint_empty_in_pattern_cop
branch
from
f1cb713
to
0cc37f6
Compare
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new
Lint/EmptyInPatterncop for Ruby 2.7's pattern matching.It checks for the presence of
inbranches without a body.This cop is similar to
Lint/EmptyWhen, but with different supported syntax and Ruby version (requires 2.7 or higher).And this PR use rubocop/rubocop-ast#183 feature, so it requires RuboCop AST 1.6.0 or higher.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.