Fix an incorrect auto-correct for Style/SingleLineMethods
#9704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the following incorrect auto-correct for `Style/SingleLineMethods`
when single line method call without parentheses.
```console
% ruby -v
ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-darwin19]
% cat example.rb
def index() head :ok end
% bundle exec rubocop --only Style/SingleLineMethods -a
(snip)
Inspecting 1 file
C
Offenses:
example.rb:1:1: C: [Corrected] Style/SingleLineMethods: Avoid
single-line method definitions.
def index() head :ok end
^^^^^^^^^^^^^^^^^^^^^^^^
1 file inspected, 1 offense detected, 1 offense corrected
```
## Before
Auto-correctd to invalid endless method definition syntax.
```ruby
% cat example.rb
def index() = head :ok
% ruby -c example.rb
example.rb:1: syntax error, unexpected symbol literal, expecting `do' or
'{' or '('
def index() = head :ok
```
## After
Auto-correctd to valid endless method definition syntax.
```ruby
% cat example.rb
def index() = head(:ok)
% ruby -c example.rb
Syntax OK
```
|
Looks good. Thanks! |
koic
deleted the
fix_an_incorrect_autocorrect_for_style_single_line_methods
branch
koic
added a commit
to koic/rubocop
that referenced
this pull request
Apr 17, 2021
This PR fixes the following error for `Style/SingleLineMethods`. ```console % cat example.rb def some_method; 42 end % bundle exec rubocop --only Style/SingleLineMethods -d (snip) undefined method `arguments' for s(:int, 42):RuboCop::AST::IntNode Did you mean? argument? /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/single_line_methods.rb:118:in `method_body_source' ``` This is a regression of rubocop#9704.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following incorrect auto-correct for
Style/SingleLineMethodswhen single line method call without parentheses.Before
Auto-correctd to invalid endless method definition syntax.
After
Auto-correctd to valid endless method definition syntax.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.