Fix an incorrect auto-correct for Lint/NumberConversion
#9633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, the following auto-correction test code is invalid syntax:
```ruby
"1,2,3,foo,5,6,7,8".split(',').map({ |i| Integer(i, 10) })
```
This PR removes invalid parentheses and auto-corrects it to valid syntax:
```ruby
"1,2,3,foo,5,6,7,8".split(',').map { |i| Integer(i, 10) }
```
Comment on lines
+125
to
+128
| def remove_parentheses(corrector, node) | ||
| corrector.replace(node.loc.begin, ' ') | ||
| corrector.remove(node.loc.end) | ||
| end |
There was a problem hiding this comment.
We have two other remove_parentheses methods defined on various cops (although they work slightly differently in each case) maybe it'd be good to normalize that at some point.
There was a problem hiding this comment.
Yeah. I didn't normalize here because each one has different behavior, but I'll look at it separately :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, the following auto-correction test code is invalid syntax:
This PR removes invalid parentheses and auto-corrects it to valid syntax:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.