Allow parentheses in operator method calls for Style/MethodCallWithArgsParentheses
#9620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
omit-parentheses-operator-methods
branch
2 times, most recently
from
463ec79
to
c05503e
Compare
|
The change is fine, but it should be reflected in the cop documentation via some examples, otherwise I don't think the users will figure out how this works. And you have to move that changelog entry. :-) |
…rgsParentheses` While calls like `data&.[] value`, `value.=== other` do compile, I won't blame people if they want to leave the parentheses so they know what's going on. I'm proposing we legitimize the parens when calling operator methods. I don't think this deserves extra configuration.
gsamokovarov
force-pushed
the
omit-parentheses-operator-methods
branch
from
c05503e
to
2e6fec1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While calls like
data&.[] value,value.=== otherdo compile, I won'tblame people if they want to leave the parentheses so they know what's
going on.
I'm proposing we legitimize the parens when calling operator methods. I
don't think this deserves extra configuration.