Prefer include? over member? in Style/CollectionMethods
#7793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Mar 11, 2020
koic
reviewed
Mar 11, 2020
|
Can you update the following diff --git a/config/default.yml b/config/default.yml
index 5049f96a1..18ac0e7f8 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -2455,7 +2455,7 @@ Style/ClassVars:
# Align with the style guide.
Style/CollectionMethods:
Description: 'Preferred collection methods.'
- StyleGuide: '#map-find-select-reduce-size'
+ StyleGuide: '#map-find-select-reduce-include-size
Enabled: false
VersionAdded: '0.9'
VersionChanged: '0.27'https://github.com/rubocop-hq/ruby-style-guide#map-find-select-reduce-include-size |
koic
approved these changes
Mar 12, 2020
|
I'm going to merge this PR because Appvayor CI failure is probably a false positive. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Style/CollectionMethodscop to preferinclude?overmember?.Per ruby-style-guide#804.