Add server mode status to -V option
#10940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_server_mode_to_version_option
branch
from
f3971bc
to
6dcd7a3
Compare
|
The changes look good, but your branch has to be rebased on top of the current |
When YJIT (disabled by default) is enabled in Ruby, it is displayed as follows. ```console % ruby --yjit -ve 'RubyVM::YJIT.enabled?' ruby 3.2.0dev (2022-08-18T08:09:08Z master b0b9f7201a) +YJIT [x86_64-darwin19] ``` `+YJIT` is added when YJIT is enabled. This is a change inspired by it. Below is before and after `rubocop -V`. ## Before ```console % rubocop -V 1.35.0 (using Parser 3.1.2.1, rubocop-ast 1.21.0, running on ruby 3.2.0 x86_64-darwin19) - rubocop-performance 1.14.3 - rubocop-rake 0.6.0 - rubocop-rspec 2.11.1 ``` ## After It makes the `-V` format like `ruby --version`. ### No server mode The platform (`x86_64-darwin19`) display will change slightly. ```console % rubocop -V 1.35.0 (using Parser 3.1.2.1, rubocop-ast 1.21.0, running on ruby 3.2.0) [x86_64-darwin19] - rubocop-performance 1.14.3 - rubocop-rake 0.6.0 - rubocop-rspec 2.11.1 ``` ### Server mode `+server` is added when server is enabled. ```console % rubocop -V 1.35.0 (using Parser 3.1.2.1, rubocop-ast 1.21.0, running on ruby 3.2.0) +server [x86_64-darwin19] - rubocop-performance 1.14.3 - rubocop-rake 0.6.0 - rubocop-rspec 2.11.1 ``` This change has the following benefits: - Shorthand alternative to `rubocop --server-status` - We can check the enable or disable of server mode in the bug report template
koic
force-pushed
the
add_server_mode_to_version_option
branch
from
6dcd7a3
to
e32e49c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When YJIT (disabled by default) is enabled in Ruby, it is displayed as follows.
+YJITis added when YJIT is enabled.This is a change inspired by it. Below is before and after
rubocop -V.Before
After
It makes the
-Vformat likeruby --version.No server mode
The platform (
x86_64-darwin19) display will change slightly.Server mode
+serveris added when server is enabled.This change has the following benefits:
rubocop --server-statusBefore submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.