Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lint/DeprecatedClassMethods aware of ENV.clone and ENV.dup #10824

Conversation

koic
Copy link
Member

@koic koic commented Jul 20, 2022

Follow up ruby/ruby#4557.

This PR makes Lint/DeprecatedClassMethods aware of ENV.clone and ENV.dup.
This update is based on the following behaviors:

% ruby -v
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-darwin19]

% ruby -we 'ENV.clone'
-e:1: warning: ENV.clone is deprecated; use ENV.to_h instead

% ruby -e 'ENV.dup'
-e:1:in `dup': Cannot dup ENV, use ENV.to_h to get a copy of ENV as a hash (TypeError)
        from -e:1:in `<main>'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow up ruby/ruby#4557.

This PR makes `Lint/DeprecatedClassMethods` aware of `ENV.clone` and `ENV.dup`.
This update is based on the following behaviors:

```console
% ruby -v
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-darwin19]

% ruby -we 'ENV.clone'
-e:1: warning: ENV.clone is deprecated; use ENV.to_h instead

% ruby -e 'ENV.dup'
-e:1:in `dup': Cannot dup ENV, use ENV.to_h to get a copy of ENV as a hash (TypeError)
        from -e:1:in `<main>'
```
@koic koic merged commit 2f8d8c7 into rubocop:master Jul 20, 2022
@koic koic deleted the make_lint_deprecated_class_methods_aware_of_env_clone_and_dup branch July 20, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant