Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add autocorrect support for Style/SafeNavigationChain #10817

Conversation

r7kamura
Copy link
Contributor

I know that the autocorrect support was removed once at #5606. But I think it was removed because there was no distinction between --autocorrect and --autocorrect-all at the time.
Could we add it once more again?


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@r7kamura r7kamura force-pushed the feature/style-safe-navigation-chaing-autocorrect branch from 2978a94 to dacd386 Compare July 14, 2022 21:32
@r7kamura r7kamura force-pushed the feature/style-safe-navigation-chaing-autocorrect branch from dacd386 to 73b54ae Compare July 14, 2022 21:43
@bbatsov bbatsov merged commit 83893ce into rubocop:master Jul 15, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Jul 15, 2022

Yes, we can! I think that it's good to have autocorrect for this particular cop. Thanks!

@r7kamura r7kamura deleted the feature/style-safe-navigation-chaing-autocorrect branch July 15, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants