Support csend on Style/SymbolProc
#10810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Thanks! |
koic
reviewed
Jul 13, 2022
| @@ -0,0 +1 @@ | |||
| * [#10810](https://github.com/rubocop/rubocop/pull/10810): Support `csend` on `Style/SymbolProc`. ([@r7kamura][]) | |||
There was a problem hiding this comment.
Suggested change
| * [#10810](https://github.com/rubocop/rubocop/pull/10810): Support `csend` on `Style/SymbolProc`. ([@r7kamura][]) | |
| * [#10810](https://github.com/rubocop/rubocop/pull/10810): Support safe navigation operator on `Style/SymbolProc`. ([@r7kamura][]) |
koic
reviewed
Jul 13, 2022
| @@ -81,7 +81,7 @@ class SymbolProc < Base | |||
| def_node_matcher :proc_node?, '(send (const {nil? cbase} :Proc) :new)' | |||
|
|
|||
| # @!method symbol_proc_receiver?(node) | |||
| def_node_matcher :symbol_proc_receiver?, '{(send ...) (super ...) zsuper}' | |||
| def_node_matcher :symbol_proc_receiver?, '{({csend | send} ...) (super ...) zsuper}' | |||
There was a problem hiding this comment.
Suggested change
| def_node_matcher :symbol_proc_receiver?, '{({csend | send} ...) (super ...) zsuper}' | |
| def_node_matcher :symbol_proc_receiver?, '{(call ...) (super ...) zsuper}' |
koic
reviewed
Jul 13, 2022
| @@ -12,6 +12,17 @@ | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'registers an offense for csend' do | |||
There was a problem hiding this comment.
Suggested change
| it 'registers an offense for csend' do | |
| it 'registers an offense for safe navigation operator' do |
|
The comments were delayed, please never mind. |
8 tasks
koic
pushed a commit
that referenced
this pull request
Jul 14, 2022
koic
added a commit
that referenced
this pull request
Jul 14, 2022
Improve `Style/SymbolProc` about #10810 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the following bad side code should also be treated as an offense:
Before submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.