Fix false negatives when public method is defined after a private one #10774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darhazer
force-pushed
the
fix-documentation-comment-false-negatives
branch
from
6dec6be
to
231fa5d
Compare
koic
reviewed
Jun 29, 2022
lib/rubocop/cop/mixin/def_node.rb
Outdated
| @@ -5,8 +5,7 @@ module Cop | |||
| # Common functionality for checking def nodes. | |||
| module DefNode | |||
| extend NodePattern::Macros | |||
|
|
|||
| NON_PUBLIC_MODIFIERS = %w[private protected].freeze | |||
| include ::RuboCop::Cop::VisibilityHelp | |||
There was a problem hiding this comment.
Can you update it?
Suggested change
| include ::RuboCop::Cop::VisibilityHelp | |
| include VisibilityHelp |
Darhazer
force-pushed
the
fix-documentation-comment-false-negatives
branch
from
231fa5d
to
8d02cda
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Rails/Delegate this cop was just checking the previous lines for a
privatedeclaration. This fails when there is a private method in a nested class, or as the added spec illustrates - when private methods are declared before the public onesBefore submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.