Recover 7x slow running rubocop
#10750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recovers rubocop#10735 regression. This PR recovers 7x slower running `rubocop`. ## v1.30.1 Originally it was about 12 seconds: ```console % git chceckout v1.30.1 % bundle exec rubocop --display-time Inspecting 1366 files (snip) 1366 files inspected, no offenses detected Finished in 12.27936500031501 seconds ``` ## master (v1.31.0 / after rubocop#10735) 7x slower in my local environment: ```console % bundle exec rubocop --display-time Inspecting 1393 files (snip) 1393 files inspected, no offenses detected Finished in 88.82363200001419 seconds ``` ## This patch It recovers to the same speed as v1.30.1: ```console % bundle exec rubocop --display-time Inspecting 1393 files (snip) 1393 files inspected, no offenses detected Finished in 12.322518999688327 seconds ``` The cause has not been clarified yet, but it seems that it was caused by changing `require_relative` to `autoload` in rubocop#10735. This PR change to `require_relative` to resolve the cause of the delay.
koic
force-pushed
the
recover_slow_running_rubocop
branch
from
cf82530
to
a4039ae
Compare
5 tasks
|
Pretty weird indeed. Probably we'll need to cut a new release in the next couple of this, because of this. |
|
I'm sorry for the trouble. I also hope it will be released soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recovers #10735 regression.
This PR recovers 7x slower running
rubocop.v1.30.1
Originally it was about 12 seconds:
master (v1.31.0 / after #10735)
7x slower in my local environment:
This patch
It recovers to the same speed as v1.30.1:
The cause has not been clarified yet, but it seems that it was caused by changing
require_relativetoautoloadin #10735.This PR change to
require_relativeto resolve the cause of the delay.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.