Fix Style/BlockDelimiters for blocks with numbered arguments #10749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
EnforcedStyle
ofline_count_based
, the default, the following code will issue an offense, and will be auto-corrected:While the code below won't be converted to a multiline
do ... end
block:This is yet another case of missing
on_numblock
implementation. I see a dozen of those in the codebase and I think whenever we handleblock
AST nodes we should also handlenumblock
nodes. I can go over the codebase and fix those problems on a per-cop basis, or I can try to fix it generally.Currently, my best idea is to write an
InternalAffairs
cop that warns when we defineon_block
handlers, but we miss anon_numblock
implementation. For the majority of the cases,on_numblock
alias of theon_block
method would be enough to handle blocks with numbered arguments. I can then use the internal cop and systematically go over the cases and add aliases or customnumblock
handlers where required. I think this is better than solutions involving meta-programming or defaulton_numblock
implementations delegating toon_block
.[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.