Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Layout/SpaceInsideBlockBraces for blocks with numbered arguments #10736

Merged
merged 1 commit into from Jun 22, 2022

Conversation

gsamokovarov
Copy link
Contributor

@gsamokovarov gsamokovarov commented Jun 22, 2022

The Layout/SpaceInsideBlockBraces was not being applied for blocks with
numbered arguments as they have AST node type of numblock and the cop
only ran for block nodes.

At Dext we caught spacing errors during code review and wandered why the
cop didn't run at all. The piece of code was in the lines of:

Tax.where(condition).partition {_1.by_something}

Not running Layout/SpaceInsideBlockBraces for numblock nodes was the
cause.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

The `Layout/SpaceInsideBlockBraces` was not being applied for blocks with
numbered arguments as they have AST node type of `numblock` and the cop
only ran for `block` nodes.

At Dext we caught spacing errors during code review and wandered why the
cop didn't run at all. The piece of code was in the lines of

```ruby
Tax.where(condition).partition {_1.by_something}
```

Not running Layout/SpaceInsideBlockBraces for `numblock` nodes was the
cause.
@koic koic merged commit 0d09460 into rubocop:master Jun 22, 2022
@koic
Copy link
Member

koic commented Jun 22, 2022

Thank you, Genadi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants