Rename custom rake task to rubocop:autocorrect
#10709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up rubocop#10547. This PR renames custom rake task from `rubocop:auto_correct` to `rubocop:autocorrect`. ## Before ```console rake rubocop # Run RuboCop rake rubocop:auto_correct # Autocorrect RuboCop offenses ``` ## After ```console rake rubocop # Run RuboCop rake rubocop:autocorrect # Autocorrect RuboCop offenses ``` For compatibility, `rubocop:auto_correct` task is left, but the task is deprecated and does not display in `rake -T`. When executed, the following warning will be displayed: ```console % bundle exec rake rubocop:auto_correct rubocop:auto_correct task is deprecated; use rubocop:autocorrect task instead. Running RuboCop... ```
koic
force-pushed
the
rename_custom_rake_task_to_rubocop_autocorrect
branch
from
1b6f2c1
to
742f3e4
Compare
|
Thanks! |
alexjfisher
reviewed
Jun 23, 2022
|
|
||
| task(:auto_correct, *args) do |_, task_args| | ||
| desc 'Autocorrect RuboCop offenses' | ||
| task(:autocorrect, *args) do |_, task_args| | ||
| RakeFileUtils.verbose(verbose) do | ||
| yield(*[self, task_args].slice(0, task_block.arity)) if task_block | ||
| options = full_options.unshift('--autocorrect-all') |
There was a problem hiding this comment.
When I saw this PR, I was hoping that the rake task would now default to safe auto corrects only.
There was a problem hiding this comment.
@bbatsov Since this has been merged, but not been released yet, how would you feel about a new PR that adds a rubocop:autocorrect_all task?
The deprecated rubocop:auto_correct task could invoke this one, and the new rubocop:autocorrect could be changed to do safe changes only?
There was a problem hiding this comment.
I've opened #10746 to solve it.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jun 24, 2022
…correct_all` Follow up rubocop#10709 (comment). This PR splits deprecated `rubocop:auto_correct` custom rake task into `rubocop:autocorrect` and `rubocop:autocorrect_all`.
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
Jun 24, 2022
…correct_all` Follow up #10709 (comment). This PR splits deprecated `rubocop:auto_correct` custom rake task into `rubocop:autocorrect` and `rubocop:autocorrect_all`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #10547.
This PR renames custom rake task from
rubocop:auto_correcttorubocop:autocorrect.Before
After
For compatibility,
rubocop:auto_correcttask is left, but the task is deprecated and does not display inrake -T.When executed, the following warning will be displayed:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.