Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10374] Fix a false positive for Layout/LineLength when long URIs in yardoc comments to have titles #10459

Merged
merged 1 commit into from Mar 22, 2022

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 18, 2022

Fixes #10374

This PR fixes a false positive for Layout/LineLength when when long URIs in yardoc comments to have titles.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

… long URIs in yardoc comments to have titles
@ydah ydah marked this pull request as ready for review March 18, 2022 17:23
@bbatsov bbatsov merged commit 6c10b64 into rubocop:master Mar 22, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 22, 2022

Looks good. Thanks!

@ydah ydah deleted the fix-layout-line-length branch March 22, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/LineLength AllowURI does not allow long URLs in yardoc comments to have titles
2 participants