Fix a false positive for Security/YamlLoad
#10424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a false positive for `Security/YamlLoad` when using Ruby 3.1+ (Psych 4). And it also makes the examples a bit more specific. Ruby 3.1+ (Psych 4) uses `Psych.load` as `Psych.safe_load` by default. ruby/psych#487 We may consider removing this cop in the future, but not yet.
koic
force-pushed
the
fix_a_false_positive_for_security_yaml_load
branch
from
e89f7e2
to
0a8ad1b
Compare
Indeed. |
koic
added a commit
that referenced
this pull request
Feb 29, 2024
Follow #10424. Ruby 3.1+ (Psych 4) uses `Psych.load` as `Psych.safe_load` by default. So, only Ruby 3.0 and earlier will be warned about using `YAML.load`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a false positive for
Security/YamlLoadwhen using Ruby 3.1+ (Psych 4).And it also makes the examples a bit more specific.
Ruby 3.1+ (Psych 4) uses
Psych.loadasPsych.safe_loadby default.ruby/psych#487
We may consider removing this cop in the future, but not yet.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.