Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Lint/InheritException as unsafe auto-correction #10408

Merged
merged 1 commit into from Feb 11, 2022

Conversation

koic
Copy link
Member

@koic koic commented Feb 9, 2022

This PR marks Lint/InheritException as unsafe auto-correction.

This cop's autocorrection is unsafe because rescue that omit exception class handle StandardError and its subclasses,
but not Exception and its subclasses.

begin
rescue # Handles only `StandardError` and its subclasses because exception class is omitted.
end

It's still unsafe after #10406 is resolved.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the mark_lint_inherit_exception_as_unsafe branch from dcdc3d9 to b91c4d4 Compare February 9, 2022 16:48
This PR marks `Lint/InheritException` as unsafe auto-correction.

This cop's autocorrection is unsafe because `rescue` that omit
exception class handle `StandardError` and its subclasses,
but not `Exception` and its subclasses.

```ruby
begin
rescue # Handles only `StandardError` and its subclasses because exception class is omitted.
end
```

It's still unsafe after rubocop#10406 is resolved.
@koic koic changed the title Mark Lint/InheritException as unsafe Mark Lint/InheritException as unsafe auto-correction Feb 9, 2022
@koic koic force-pushed the mark_lint_inherit_exception_as_unsafe branch from b91c4d4 to bc9d310 Compare February 9, 2022 16:52
@bbatsov bbatsov merged commit 4a3d37b into rubocop:master Feb 11, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 11, 2022

Thanks!

@koic koic deleted the mark_lint_inherit_exception_as_unsafe branch February 11, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants