Change EnforcedStyle
to standard_error
for Lint/InheritException
#10407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change
EnforcedStyle
fromruntime_error
tostandard_error
forLint/InheritException
.I noticed this while investigating #10406.
Below is the inheritance tree for the exception classes.
AFAIK, it seems that custom exceptions generally inherit from
StandardError
.Subclasses of
StandardError
are handled withrescue
by default.raise
creates aRuntimeError
when the exception class is omitted.If custom exception inherits from
RuntimeError
, the custom exception andRuntimeError
will be is-a.If custom exception inherits from
StandardError
, the custom exception andRuntimeError
will not be is-a.In other words, inheriting
StandardError
will not be mistakenly handled asraise
which omits the exception class.So, inheriting
StandardError
rather thanRuntimeError
does not include unnecessary inheritance forrescue
handling.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.