Change EnforcedStyle to standard_error for Lint/InheritException
#10407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR change `EnforcedStyle` from `runtime_error` to `standard_error` for `Lint/InheritException`. I noticed this while investigating rubocop#10406. Below is the inheritance tree for the exception classes. ``` --------------- | Exception | --------------- ^ | --------------- |StandardError| (default for `rescue`) --------------- ^ | --------------- |RuntimeError | (default for `raise`) --------------- ``` AFAIK, it seems that custom exceptions generally inherit from `StandardError`. Subclasses of `StandardError` are handled with `rescue` by default. `raise` creates a `RuntimeError` when the exception class is omitted. If custom exception inherits from `RuntimeError`, the custom exception and `RuntimeError` will be is-a. If custom exception inherits from `StandardError`, the custom exception and `RuntimeError` will not be is-a. In other words, inheriting `StandardError` will not be mistakenly handled as `raise` which omits the exception class. So, inheriting `StandardError` rather than `RuntimeError` does not include unnecessary inheritance for `rescue` handling.
koic
force-pushed
the
change_enforced_style_for_lint_inherit_exception
branch
from
7f472a0
to
bb3a8ab
Compare
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change
EnforcedStylefromruntime_errortostandard_errorforLint/InheritException.I noticed this while investigating #10406.
Below is the inheritance tree for the exception classes.
AFAIK, it seems that custom exceptions generally inherit from
StandardError.Subclasses of
StandardErrorare handled withrescueby default.raisecreates aRuntimeErrorwhen the exception class is omitted.If custom exception inherits from
RuntimeError, the custom exception andRuntimeErrorwill be is-a.If custom exception inherits from
StandardError, the custom exception andRuntimeErrorwill not be is-a.In other words, inheriting
StandardErrorwill not be mistakenly handled asraisewhich omits the exception class.So, inheriting
StandardErrorrather thanRuntimeErrordoes not include unnecessary inheritance forrescuehandling.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.