Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide thresholds ontop as recommendations instead of failing hard on issues #10219

Open
OneDivZero opened this issue Oct 27, 2021 · 1 comment

Comments

@OneDivZero
Copy link

Problem

Default settings are mostly sophisticated and often really frustrating. This has nothing to do with real issues, if you are an experienced developer. So actually my class has now e.g. for 'Metrics/MethodLength' currently 3+ lines over rubocops recommendation. I had done every possible optimization ... and now?

Thoughts

  • First thought: GFY rubocop (bad experience for a supporting tool)
  • Second thought: Something extractable or refactorable?
  • Third thought: Nope, this class is fine, but only has 3 lines over the top

So what should I do now ?

  • Put everytime an annoying disable-statement on top of the class
  • Or just silence rubocop by changing the max-value via config
  • Problem: the latter is globally applied ... maybe not a good ideal!

Solution:

You all know soft-quotas and hard-quotas from filesystems ... this is an easy concept!
So we just can add another keyword to the yaml-config named :quota beside existing :max ...

Or maybe rethink the whole stuff accoding to having a quota-warning in general, with some tolerance instead of hard-failures (esp. inside ci-pipelines)! Recap there is also a social aspect, which covers learning-theories ontop. Let us make devlopers feeling good every day, instead of feeling sadly, cause rubocop fails again.

My thoughts are overwhelming a plain technical discussion ... Feel free to comment your personal thoughts!

@dvandersluis
Copy link
Member

I've been thinking about this, but I'm not sure how it would work practically. How would a soft limit function? If it doesn't raise a warning then it might as well just be the hard limit anyways, and if it does raise a warning, then is it any different than what you're currently running into?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants