Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Style/AndOr as unsafe auto-correction #10068

Merged

Conversation

koic
Copy link
Member

@koic koic commented Sep 8, 2021

This PR marks Style/AndOr as unsafe auto-correction.

cf: rubocop/rubocop-rails#210


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR marks `Style/AndOr` as unsafe auto-correction.

cf: rubocop/rubocop-rails#210
@koic koic force-pushed the mark_style_and_or_as_unsafe_auto_correction branch from 8bd8e04 to 7d45c0d Compare September 8, 2021 01:41
@bbatsov bbatsov merged commit 6d1ce3b into rubocop:master Sep 9, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 9, 2021

Thanks!

@koic koic deleted the mark_style_and_or_as_unsafe_auto_correction branch September 9, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants