Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lint/Debugger aware of debug.rb #10040

Merged
merged 1 commit into from Aug 25, 2021

Conversation

koic
Copy link
Member

@koic koic commented Aug 25, 2021

This PR makes Lint/Debugger aware of debug.rb.
https://github.com/ruby/debug

debug.rb has binding.break and binding.b commands (b for short).


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR makes `Lint/Debugger` aware of debug.rb.
https://github.com/ruby/debug

debug.rb has `binding.break` and `binding.b` commands (`b` for short).
@koic koic force-pushed the make_lint_debugger_aware_of_debug_rb branch from b93802a to d94451e Compare August 25, 2021 06:22
@bbatsov bbatsov merged commit 9ff50d1 into rubocop:master Aug 25, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 25, 2021

Thanks!

@koic koic deleted the make_lint_debugger_aware_of_debug_rb branch August 25, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants