Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9928] Fix a false auto-correct for Layout/EndAlignment #9932

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jul 14, 2021

Fixes #9928.

This PR fixes an infinite loop error and a false auto-correction behavior for Layout/EndAlignment when using operator methods and EnforcedStyleAlignWith: variable.
This infinite loop error is due to an offense being registered but not auto-corrected.

EnforcedStyleAlignWith: variable enforces alignment to variable, it should be auto-corrected to be aligned to variable even when operator method is used.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#9928.

This PR fixes an infinite loop error and a false auto-correction behavior for `Layout/EndAlignment`
when using operator methods and `EnforcedStyleAlignWith: variable`.
This infinite loop error is due to an offense being registered but not auto-corrected.

`EnforcedStyleAlignWith: variable` enforces alignment to variable,
it should be auto-corrected to be aligned to variable even when operator method is used.
@jonas054
Copy link
Collaborator

Looks good to me. 👍

@koic koic merged commit 3907e07 into rubocop:master Jul 18, 2021
@koic koic deleted the fix_false_autocorrection_for_layout_end_alignment branch July 18, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop on Layout/EndAlignment (with EnforcedStyleAlignWith: variable)
2 participants