1.times for block with argument incorrectly auto-corrected

[msbit]

With the following code:

1.times do |i|
  puts i
end

which, when run, outputs: 0

if considered by rubocop with --auto-correct-all enabled, produces the following auto-corrected code:

# frozen_string_literal: true

puts 1

which, when run, outputs: 1

---

Expected behavior

Auto-correct use of 1.times to block invocation with 0 as the argument.

Actual behavior

Auto-correct use of 1.times to block invocation with 1 as the argument.

Steps to reproduce the problem

• Create Ruby file containing:

1.times do |i|
  puts i
end

• Run rubocop --auto-correct-all <file.rb>

RuboCop version

$ rubocop -V
1.18.2 (using Parser 3.0.1.1, rubocop-ast 1.7.0, running on ruby 2.7.3 x86_64-darwin19)

[msbit]

Could be as simple as a change to the replacement at

rubocop/lib/rubocop/cop/lint/useless_times.rb

Line 84 in 1e55b1a

source.gsub!(/\b#{block_arg}\b/, '1') if block_arg

?

[koic]

Yep. I've opened #9908. Thank you.