Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9874] Fix a false positive for Style/RegexpLiteral #9878

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 15, 2021

Fixes #9874.

This PR fixes a false positive for Style/RegexpLiteral when using %r regexp literal with EnforcedStyle: omit_parentheses of Style/MethodCallWithArgsParentheses.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#9874.

This PR fixes a false positive for `Style/RegexpLiteral`
when using `%r` regexp literal with `EnforcedStyle: omit_parentheses` of
`Style/MethodCallWithArgsParentheses`.
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 15, 2021

@koic Looks good! Can you please merge this and cut a new release later today, as I'm traveling for the next few days and there's an important bugfix we need to ship.

@koic
Copy link
Member Author

koic commented Jun 15, 2021

@bbatsov I get it! I will release RuboCop 1.17 later today.

@koic koic merged commit 956a9b1 into rubocop:master Jun 15, 2021
@koic koic deleted the fix_false_positive_for_style_regexp_literal branch June 15, 2021 10:01
@koic
Copy link
Member Author

koic commented Jun 15, 2021

RuboCop 1.17 is out :-)
https://github.com/rubocop/rubocop/releases/tag/v1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/RegexpLiteral not accounting for ambigous first argument
2 participants