Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #9808" - fix MinGW CI #9856

Merged
merged 1 commit into from Jun 5, 2021

Conversation

MSP-Greg
Copy link
Contributor

@MSP-Greg MSP-Greg commented Jun 5, 2021

MinGW master build problem addressed in PR #9808 is fixed.

This reverts commit ac00a83, reversing
changes made to 5f64524.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…w_build_error"

This reverts commit ac00a83, reversing
changes made to 5f64524.
@MSP-Greg MSP-Greg mentioned this pull request Jun 5, 2021
8 tasks
@koic koic merged commit a8ba2f9 into rubocop:master Jun 5, 2021
@koic
Copy link
Member

koic commented Jun 5, 2021

Thank you @MSP-Greg!

@MSP-Greg MSP-Greg deleted the mingw-ci branch June 5, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants