Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint/EmptyInPattern AllowComments isn't supported #9850

Closed
bkuhlmann opened this issue Jun 4, 2021 · 0 comments · Fixed by #9851
Closed

Lint/EmptyInPattern AllowComments isn't supported #9850

bkuhlmann opened this issue Jun 4, 2021 · 0 comments · Fixed by #9851
Labels

Comments

@bkuhlmann
Copy link

bkuhlmann commented Jun 4, 2021

Expected behavior

Per the documentation, it appears you can't use AllowComments unless the documentation has a typo?

Actual behavior

When running Rubocop, I see the following output:

iTerm2-Yurz0JFI

Steps to reproduce the problem

Use the following Rubocop configuration:

Lint/EmptyInPattern:
  Enabled: true
  AllowComments: false

Then run Rubocop on any Ruby file with the above configuration to see the behavior shown above.

RuboCop version

1.16.0 (using Parser 3.0.1.1, rubocop-ast 1.7.0, running on ruby 3.0.1 arm64-darwin20)
  - rubocop-performance 1.11.3
  - rubocop-rake 0.5.1
  - rubocop-rspec 2.3.0
@koic koic added the bug label Jun 4, 2021
koic added a commit to koic/rubocop that referenced this issue Jun 4, 2021
Fixes rubocop#9850.

This PR fixes missing `AllowComments` option for `Lint/EmptyInPattern`.
dvandersluis added a commit that referenced this issue Jun 4, 2021
…in_pattern

[Fix #9850] Fix missing option for `Lint/EmptyInPattern`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants