Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9839] Add AllowedReceivers option for Style/HashEachMethods #9840

Conversation

koic
Copy link
Member

@koic koic commented May 31, 2021

Fixes #9839.

This PR adds AllowedReceivers option for Style/HashEachMethods.

Style/HashEachMethods cop is already marked as unsafe. This PR can use allow list to rule out false positives.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ethods`

Fixes rubocop#9839.

This PR adds `AllowedReceivers` option for `Style/HashEachMethods`.

`Style/HashEachMethods` cop is already marked as unsafe.
This PR can use allow list to rule out false positives.
@koic koic force-pushed the add_allowed_receivers_option_for_style_hash_each_methods branch from f6558e0 to c1773e1 Compare May 31, 2021 07:47
@bbatsov bbatsov merged commit 6dfcb7a into rubocop:master May 31, 2021
@koic koic deleted the add_allowed_receivers_option_for_style_hash_each_methods branch May 31, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in Style/HashEachMethods
3 participants