Add rubocop-rake #9813
Merged
Add rubocop-rake #9813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but you'll have to fix the broken build. |
|
@tejasbubane ping :-) |
|
Waiting for rubocop/rubocop-rake#37 to be merged. |
koic
reviewed
Jun 28, 2021
Gemfile
Outdated
| @@ -11,6 +11,7 @@ gem 'rspec', '~> 3.7' | |||
| # RuboCop Performance upgrade to 1.11 is postponed until | |||
| # https://github.com/rubocop/rubocop/pull/9721 will be resolved. | |||
| gem 'rubocop-performance', '~> 1.10.0' | |||
| gem 'rubocop-rake', '~> 0.5.1' | |||
There was a problem hiding this comment.
RuboCop Rake 0.6.0 has been released. Can you update to 0.6.0?
https://github.com/rubocop/rubocop-rake/releases/tag/v0.6.0
Suggested change
| gem 'rubocop-rake', '~> 0.5.1' | |
| gem 'rubocop-rake', '~> 0.6.0' |
koic
reviewed
Jun 28, 2021
tasks/prof.rake
Outdated
| @@ -10,6 +10,7 @@ namespace :prof do | |||
| system cmd | |||
| end | |||
|
|
|||
| desc 'Run Rubocop on itself only if dump does not exist' | |||
There was a problem hiding this comment.
Suggested change
| desc 'Run Rubocop on itself only if dump does not exist' | |
| desc 'Run RuboCop on itself only if dump does not exist' |
tejasbubane
force-pushed
the
rubocop-rake
branch
from
3534228
to
98ffefb
Compare
tejasbubane
force-pushed
the
rubocop-rake
branch
from
98ffefb
to
e74ff40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rubocop/rubocop-rake
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.