Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9762] Update VariableForce to be able to handle case-match nodes #9764

Merged
merged 1 commit into from May 3, 2021

Conversation

dvandersluis
Copy link
Member

VariableForce::Branch was not aware of case-match nodes and thus did not properly mark all assignments in the following code as used, which caused rubocop to register a false positive Lint/UselessAssignment.

def f
 case '0'
 in String
   res = 1 # would not be registered, causing an offense
 else
   res = 2 # would be registered
 end
 res
end

Fixes #9762.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis
Copy link
Member Author

Applied your suggestions, thanks @koic!

@koic koic merged commit d0df484 into rubocop:master May 3, 2021
@koic
Copy link
Member

koic commented May 3, 2021

Great! Thank you @dvandersluis!

@dvandersluis dvandersluis deleted the issue/9762 branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/UselessAssignment: bad behavior with pattern matching
2 participants