Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration parameter to Layout/RedundantLineBreak #9691

Closed
jonas054 opened this issue Apr 10, 2021 · 0 comments
Closed

Add configuration parameter to Layout/RedundantLineBreak #9691

jonas054 opened this issue Apr 10, 2021 · 0 comments

Comments

@jonas054
Copy link
Collaborator

In #9678, @koic raised a concern that users might prefer to keep existing line breaks within blocks when using the new cop Layout/RedundantLineBreak. A configuration parameter should be added to control whether blocks are inspected or not by this cop.

I have a fix for this in the works. A PR is coming up.
jonas054 added a commit to jonas054/rubocop that referenced this issue Apr 10, 2021
@jonas054
[Fix rubocop#9691] Add configuration option InspectBlocks to Redundan…
76aa546 
…tLineBreak

Set the default value for this new configuration option to `false`, since we
suspect that many users might consider the `do`..`end` variant with line
breaks more readable.

For RuboCop's own sources we set it to `true`, i.e., the same behavior as
before the parameters existed, at least for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonas054