Calls with braces in interpolation for Style/MethodCallWithArgsParentheses
#9629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Mar 22, 2021
gsamokovarov
force-pushed
the
omit-parentheses-string-interpolation
branch
2 times, most recently
from
8f784a7
to
6791c1d
Compare
…heses
If we are calling methods in string interpolation with the `omit_parentheses`
style for the `Style/MethodCallWithArgsParentheses` cop, they are
currently forced to be without parentheses:
```ruby
"#{part 1}, #{part 2}, #{part 3}"
```
My coworkers at Dext want to be able to put spaces while calling methods
in interpolation, and I don't blame them. Having spaces reduces the
noise of following a method call in a string, especially if the string
happens to have multiple interpolations in it.
I want to add the `AllowParenthesesInStringInterpolation` cop configuration
that allows the use of parentheses in string interpolation calls.
```ruby
"#{part(1)}, #{part(2)}, #{part(3)}"
```
gsamokovarov
force-pushed
the
omit-parentheses-string-interpolation
branch
from
6791c1d
to
a34a957
Compare
|
I have moved the changelog and rewrote the documentation examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are calling methods in string interpolation with the
omit_parenthesesstyle for the
Style/MethodCallWithArgsParenthesescop, they arecurrently forced to be without parentheses:
"#{part 1}, #{part 2}, #{part 3}"My coworkers at Dext want to be able to put spaces while calling methods
in interpolation, and I don't blame them. Having spaces reduces the
noise of following a method call in a string, especially if the string
happens to have multiple interpolations in it.
I want to add the
AllowParenthesesInStringInterpolationcop configurationthat allows the use of parentheses in string interpolation calls.
"#{part(1)}, #{part(2)}, #{part(3)}"