Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cops using on_send can be optimized #8606

Closed
marcandre opened this issue Aug 27, 2020 · 2 comments · Fixed by #8644
Closed

Cops using on_send can be optimized #8606

marcandre opened this issue Aug 27, 2020 · 2 comments · Fixed by #8644
Labels
enhancement help wanted

Comments

@marcandre
Copy link
Contributor

marcandre commented Aug 27, 2020 •
edited

Now that #8365 is merged, most cops using on_send can now be optimized by defining a constant RESTRICT_ON_SEND with the list of methods the cop needs to watch for.

Cops that don't depend on a particular list of methods (say because they only look at the arguments) should be left as is.

If you want to help, just comment on which cops you want to look at first (e.g. Lint/A-E)
@fatkodima
Copy link
Contributor

Style/A-Z

@fatkodima fatkodima mentioned this issue Sep 3, 2020
Merged
@fatkodima
Copy link
Contributor

All other (except Style) departments

@fatkodima fatkodima mentioned this issue Sep 3, 2020
Merged
@mergify mergify bot closed this as completed in #8644 Sep 3, 2020
koic added a commit to koic/rubocop that referenced this issue Sep 12, 2020
@koic
Use RESTRICT_ON_SEND for Lint/IdentityComparison
9abc15c 
Follow rubocop#8699 (comment)
and rubocop#8606.

This PR uses `RESTRICT_ON_SEND` for `Lint/IdentityComparison`.
@koic koic mentioned this issue Sep 12, 2020
Merged
8 tasks
bbatsov pushed a commit that referenced this issue Sep 12, 2020
@koic @bbatsov
Use RESTRICT_ON_SEND for Lint/IdentityComparison
3686984 
Follow #8699 (comment)
and #8606.

This PR uses `RESTRICT_ON_SEND` for `Lint/IdentityComparison`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use RESTRICT_ON_SEND for the rest of cops fatkodima/rubocop
2 participants
@marcandre @fatkodima