We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There's a lot of logic in IfUnlessModifier that is missing from WhileUntilModifier.
IfUnlessModifier
WhileUntilModifier
while bar # important comment about to be nuked baz end # corrected to baz while bar
foo = while bar baz end # corrected to foo = baz while bar
This is logic that IfUnlessModifier has.
It should be moved into their shared module, and the corresponding tests should be moved in their shared context.
while foo; bar; end # => no offense
Again, IfUnless does the right thing. Same logic should be applied, tests should be moved in their shared context.
IfUnless
Found while checking #8273. See also #8282 and #8283
The text was updated successfully, but these errors were encountered:
See also #8499
Sorry, something went wrong.
[Fix #8281] Improve WhileUntilModifier detection and correction
52a2247
* Detect inline cases (while foo; bar; end) * Preserve comments when auto-correcting * Handle RHS usage in assignments
d2c2529
Darhazer
No branches or pull requests
There's a lot of logic in
IfUnlessModifier
that is missing fromWhileUntilModifier
.This is logic that
IfUnlessModifier
has.It should be moved into their shared module, and the corresponding tests should be moved in their shared context.
Again,
IfUnless
does the right thing. Same logic should be applied, tests should be moved in their shared context.Found while checking #8273. See also #8282 and #8283
The text was updated successfully, but these errors were encountered: