Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.4 #8112

Closed
tejasbubane opened this issue Jun 7, 2020 · 8 comments · Fixed by #8121
Closed

Drop support for Ruby 2.4 #8112

tejasbubane opened this issue Jun 7, 2020 · 8 comments · Fixed by #8121

Comments

@tejasbubane
Copy link
Contributor

Ruby 2.4 has reached EOL. Should we drop support for it? Perhaps this should be done as a part of 1.0 release?

Previous discussion about 2.2 & 2.3 #6945

@bbatsov Mentioned here that we should adhere to same EOL as MRI itself.

@bbatsov
Copy link
Collaborator

bbatsov commented Jun 7, 2020

Good point. Generally I don't think we have some burning need to drop 2.4, as it doesn't create much maintenance overhead, but dropping it before 1.0 might be a good idea, otherwise we might be stuck with it for a while. @rubocop-hq/rubocop-core as always, I'd love to hear your take on this.

@marcandre
Copy link
Contributor

My opinion (I don't know how prevalent it is) is that dropping compatibility with a Ruby version does not require a major version upgrade since it is part of the gem manifest and won't introduce any incompatibility with another Ruby version (as it simply won't install). So my take is that we should continue supporting it, especially since it's not a big overhead, and we can decide to drop support when we feel like it is worthwhile

@bquorning
Copy link
Contributor

I looked through old PRs to find out when we dropped support for older rubies:

If we drop support for old Rubies with the same frequency as new versions are released (once per year), I would expect us to drop support for 2.4 in April/May 2021.

@bbatsov
Copy link
Collaborator

bbatsov commented Jun 7, 2020

Thanks for looking into this! Seems we've been quite consistent in sticking to unsupported Rubies for at least a year. I guess we should update our support policy then. :-)

@koic
Copy link
Member

koic commented Jun 7, 2020

RuboCop has customarily provided support for about a year after EOL of Ruby version. And this span seems to be working as it is. I don't think it's time to drop it, as it will impact gems and apps that rely on RuboCop support.
I can take this as part of the maintenance when dropping. I think RuboCop core should provide the community with a margin of transition.

@bbatsov
Copy link
Collaborator

bbatsov commented Jun 8, 2020

Fair enough. Seems we have a deal then.

tejasbubane added a commit to tejasbubane/rubocop that referenced this issue Jun 8, 2020
Contributors came to a common conclusion in rubocop#8112

Closes rubocop#8112 since we will support 2.4 for a year.
@tejasbubane
Copy link
Contributor Author

I've added the policy to README. Should we add it somewhere else as well? Should it be shown on the docs/website?

bbatsov pushed a commit that referenced this issue Jun 8, 2020
Contributors came to a common conclusion in #8112

Closes #8112 since we will support 2.4 for a year.
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 8, 2020

Probably we should have some dedicated section on the docs about the Ruby support/compatibility policy, but we can address this down the road. I like this as a reference https://nrepl.org/nrepl/0.7.0/about/compatibility.html (probably because I wrote it myself :D )

koic added a commit to koic/rubocop that referenced this issue Jun 16, 2020
Follow up rubocop#8112 (comment).

This commit adds a doc for compatibility.
bbatsov pushed a commit that referenced this issue Jun 16, 2020
Follow up #8112 (comment).

This commit adds a doc for compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants