Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alert on raise Exception usage #7299

Closed
grosser opened this issue Aug 20, 2019 · 2 comments · Fixed by #7325
Closed

alert on raise Exception usage #7299

grosser opened this issue Aug 20, 2019 · 2 comments · Fixed by #7325
Labels
feature request good first issue Easy task, suitable for newcomers to the project

Comments

@grosser
Copy link
Contributor

grosser commented Aug 20, 2019

similar to the "do not rescue Exception" cop it would make sense to not allow raising Exception since that will bypass test frameworks and error reporters
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 21, 2019

Great idea!

@bbatsov bbatsov added the good first issue Easy task, suitable for newcomers to the project label Aug 21, 2019
@Drenmi
Copy link
Collaborator

Drenmi commented Aug 25, 2019

It's funny we didn't think of this. 😂

@denys281 denys281 mentioned this issue Sep 1, 2019
Merged
8 tasks
@denys281 denys281 mentioned this issue Sep 16, 2019
Open
denys281 added a commit to denys281/rubocop that referenced this issue Oct 28, 2019
@denys281
[Fix rubocop#7299] Implement Lint/RaiseException cop
de5e746
bbatsov added a commit that referenced this issue Mar 21, 2020
@denys281 @bbatsov
[Fix #7299] Implement Lint/RaiseException cop (#7325)
9eceed4 
Co-authored-by: Bozhidar Batsov <bozhidar@batsov.com>
@ryancyq ryancyq mentioned this issue Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue Easy task, suitable for newcomers to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #7299] Implement Lint/RaiseException cop denys281/rubocop
4 participants
@grosser @bquorning @bbatsov @Drenmi