New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style/Documentation accept constant visibility declaration as namespace #7144
Comments
AdrienSdy
added a commit
to AdrienSdy/rubocop
that referenced
this issue
Jun 16, 2019
…tation cop Extend the definition of namespaces by adding the constants visibility statement. No longer report an error for classes and modules that contain constants' visibility statements.
AdrienSdy
added a commit
to AdrienSdy/rubocop
that referenced
this issue
Aug 29, 2019
…tation cop Extend the definition of namespaces by adding the constants visibility statement. No longer report an error for classes and modules that contain constants' visibility statements.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding! |
This issue is pending reviews on the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When declare the visibility of a constant (class and module include), the namespace object get an offense to document it.
Expected behavior
Don't get an offense on the Namespace module. by considering constant visibility declaration as constant declaration.
Actual behavior
Get an offense on the Namespace module.
Steps to reproduce the problem
RuboCop version
The text was updated successfully, but these errors were encountered: