-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InternalAffairs/NodeMatcherDirective should support class methods #12665
Comments
@dvandersluis Based on you authoring #9506, this issue may be of interest to you. |
13 tasks
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this issue
Mar 6, 2024
…rDirective` with class methods
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this issue
Mar 6, 2024
…rDirective` with class methods
Merged
8 tasks
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this issue
Mar 7, 2024
…rDirective` with class methods
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this issue
Mar 7, 2024
…rDirective` with class methods
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this issue
Mar 7, 2024
…rDirective` with class methods
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this issue
Mar 7, 2024
…rDirective` with class methods
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this issue
Mar 7, 2024
…rDirective` with class methods
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this issue
Mar 8, 2024
…rDirective` with class methods
koic
added a commit
that referenced
this issue
Mar 8, 2024
[Fix #12665] Fix infinite loop for `InternalAffairs/NodeMatcherDirective` with class methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In rubocop/rubocop-rspec#1793, we are using
def_node_matcher
to define class methods. On this bit of codeI get the following result:
Note the “self.foo instead of self.” part.
Running
rubocop --autocorrect
changes the YARD comment into this monstrosity:Actually, I think the correct YARD comment for a class method might be two lines:
RuboCop version
The text was updated successfully, but these errors were encountered: