Bug/Feature Request: Breakout of Style/AccessModifierDeclaration false positives (#5953)

[luke-hill]

This is a breakout / re-opening of the old ticket. Specifically to fix the "main" use issue. (Non def defined methods shouldn't trip this up).

Expected behavior

None def defined methods should not trip this up. As an example the below code should be permissible - as it's the most common style

class Foo
  attr_reader :baz
  private :baz

  def initialize(baz)
    @baz = baz
  end

  private

  # ten_other_methods
end

Actual behavior

Same as prior to #5953 (Rubocop 0.x series)

Steps to reproduce the problem

Write the code as provided above

RuboCop version

Latest rubocop

[luke-hill]

EDIT: This does seem fixed in the latest version of rubocop. But not from the OP. So I'm going to close this as completed "at some point". I tried using rubocop 1.50+ and the cop offense isn't flagging for the above code example.

Tagging @koic for visibility