Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress "RuboCop server starting..." message with --format json --server #11164

Closed
gurgeous opened this issue Nov 8, 2022 · 0 comments · Fixed by #11167
Closed

suppress "RuboCop server starting..." message with --format json --server #11164

gurgeous opened this issue Nov 8, 2022 · 0 comments · Fixed by #11167
Labels
bug

Comments

@gurgeous
Copy link

gurgeous commented Nov 8, 2022

Expected behavior

Running --server with --format json should try to produce valid JSON. This simplifies IDE integration.

Actual behavior

$ rubocop test.rb --server --format json
RuboCop server starting on 127.0.0.1:64692.
{"metadata": ... }

Steps to reproduce the problem

see above

RuboCop version

1.38.0
@gurgeous gurgeous mentioned this issue Nov 8, 2022
Merged
@koic koic added the bug label Nov 9, 2022
@koic koic mentioned this issue Nov 9, 2022
Merged
8 tasks
koic added a commit to koic/rubocop that referenced this issue Nov 9, 2022
@koic
[Fix rubocop#11164] Suppress a server mode message
bf3d4e4 
Fixes rubocop#11164

This PR suppresses "RuboCop server starting..." message with `--server --format json`
because JSON format does not expected output message when IDE integration with server mode.
bbatsov pushed a commit that referenced this issue Nov 10, 2022
@koic @bbatsov
[Fix #11164] Suppress a server mode message
37d7c02 
Fixes #11164

This PR suppresses "RuboCop server starting..." message with `--server --format json`
because JSON format does not expected output message when IDE integration with server mode.
@jasondoc3 jasondoc3 mentioned this issue Mar 6, 2023
Merged
8 tasks
bbatsov pushed a commit that referenced this issue Mar 6, 2023
@jasondoc3
[Fix #11164] Suppress server mode message with -f json (#11668)
af8b5f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #11164] Suppress a server mode message koic/rubocop
2 participants
@koic @gurgeous