Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style/HashEachMethods doesn't detect &blocks #11139

Closed
vlad-pisanov opened this issue Nov 1, 2022 · 0 comments · Fixed by #11140
Closed

Style/HashEachMethods doesn't detect &blocks #11139

vlad-pisanov opened this issue Nov 1, 2022 · 0 comments · Fixed by #11140
Labels
bug

Comments

@vlad-pisanov
Copy link

Currently, Style/HashEachMethods detects regular blocks and numblocks, but ignores &blocks:

h.keys.each { ... }
# Style/HashEachMethods suggests: h.each_key { ... } ✔️

h.keys.each(&:foo)
# Style/HashEachMethods ignores ❌

Ideally, it should recommend:

h.each_key(&:foo)
@ydah ydah mentioned this issue Nov 1, 2022
Merged
8 tasks
@koic koic added the bug label Nov 2, 2022
@si-lens si-lens mentioned this issue Nov 2, 2022
Merged
8 tasks
ydah added a commit to ydah/rubocop that referenced this issue Nov 6, 2022
@ydah
[Fix rubocop#11139] Fix a false negative for Style/HashEachMethods …
fc95138 
…when using each with a symbol proc argument

Fix: rubocop#11139
koic added a commit that referenced this issue Nov 6, 2022
@koic
Merge pull request #11140 from ydah/fix_hash_each_methods
43bf78e 
[Fix #11139] Fix a false negative for `Style/HashEachMethods` when using each with a symbol proc argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@koic @vlad-pisanov