Style/RedundantStringEscape cop is crashing on some rare inputs #11089
Labels
Comments
|
@owst Please, take a look. |
8 tasks
ydah
added a commit
to ydah/rubocop
that referenced
this issue
Oct 21, 2022
…en using character literals (e.g. `?a`) Fix: rubocop#11089
koic
added a commit
that referenced
this issue
Oct 21, 2022
[Fix #11089] Fix an error for `Style/RedundantStringEscape` when using character literals (e.g. `?a`)
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this issue
Oct 21, 2022
This PR fixes the following error for `Style/RedundantStringEscape` cop
when using `?\n` string character literal.
```console
% cat example.rb
?\n
% bundle exec rubocop --only Style/RedundantStringEscape -d
(snip)
An error occurred while Style/RedundantStringEscape cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/11090/example.rb:1:0.
undefined method `source' for nil:NilClass
delimiters = [node.loc.begin.source[-1], node.loc.end.source[0]]
^^^^^^^
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:162:in `delimiter?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:110:in `single_quoted?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:103:in `interpolation_not_enabled?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:85:in `allowed_escape?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:51:in `block in on_str'
```
Similar case to rubocop#11089, but not resolved by rubocop#11090.
It also removes a bit of unnecessary implementation logic I found.
bbatsov
pushed a commit
that referenced
this issue
Oct 21, 2022
This PR fixes the following error for `Style/RedundantStringEscape` cop
when using `?\n` string character literal.
```console
% cat example.rb
?\n
% bundle exec rubocop --only Style/RedundantStringEscape -d
(snip)
An error occurred while Style/RedundantStringEscape cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/11090/example.rb:1:0.
undefined method `source' for nil:NilClass
delimiters = [node.loc.begin.source[-1], node.loc.end.source[0]]
^^^^^^^
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:162:in `delimiter?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:110:in `single_quoted?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:103:in `interpolation_not_enabled?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:85:in `allowed_escape?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:51:in `block in on_str'
```
Similar case to #11089, but not resolved by #11090.
It also removes a bit of unnecessary implementation logic I found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code as follows cause cop to crash:
Expected behavior
The cop should not crash. Rubocop probably can suggest to rewrite the code like
["one", "two"].join("."), but not crash.Actual behavior
An error occurred while Style/RedundantStringEscape cop was inspecting ...RuboCop version
The text was updated successfully, but these errors were encountered: