Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve singleton method example on Lint/UselessAccessModifier cop #10984

Merged
merged 1 commit into from Sep 1, 2022

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Sep 1, 2022

It is not appropriate to use public in this example.

# bad
class Foo
  public

  def self.method3
  end
end

As explained in the previous example, the access is public by default, which makes no sense regardless of whether it is a singleton method or not.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit ca5b3c3 into rubocop:master Sep 1, 2022
@r7kamura r7kamura deleted the feature/modifier-example branch September 1, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants