[Fix #10979] Fix a false positive for Style/Style/RedundantParentheses
#10981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
koic
reviewed
Aug 30, 2022
| @@ -29,6 +29,9 @@ class RedundantParentheses < Base | |||
| # @!method rescue?(node) | |||
| def_node_matcher :rescue?, '{^resbody ^^resbody}' | |||
|
|
|||
| # @!method pin_operator?(node) | |||
| def_node_matcher :pin_operator?, '^(pin (begin !{lvar ivar cvar gvar}))' | |||
There was a problem hiding this comment.
The matcher name pin_operator? is abstract. How about the names allowed_pin_operator? or pin_operator_with_var?
…rentheses` Fixes rubocop#10979. This PR fixes a false positive for `Style/RedundantParentheses` when using parentheses with pin operator except for variables.
Tietew
force-pushed
the
fix_a_false_positive_for_style_redundant_parentheses
branch
from
b7d58a0
to
45403e3
Compare
Tietew
deleted the
fix_a_false_positive_for_style_redundant_parentheses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10979.
This PR fixes a false positive for
Style/RedundantParentheseswhen using parentheses with pin operator except for variables.This PR also allows literals because:
foo in { bar: ^(1) }should be corrected tofoo in { bar: 1 }.foo in { bar: ^([1]) }should be corrected tofoo in { bar: [1] }.foo in { bar: ^([var]) }should be allowed becausefoo in { bar: [var] }performs capture.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.