Use GitHub Actions instead of CircleCI for JRuby matrix #10932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
use_official_jruby_image
branch
from
f1155fd
to
c4f944d
Compare
koic
added a commit
that referenced
this pull request
Aug 17, 2022
This commit fixes an incompatibility detected by upgrading JRuby version: #10932 This issue has been reported to jruby/jruby#7316.
koic
force-pushed
the
use_official_jruby_image
branch
from
c4f944d
to
b6c7f96
Compare
8 tasks
|
The reason why the circleci jruby images haven't been updated is because they have deprecated jruby https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034#deprecated-images-3 |
koic
force-pushed
the
use_official_jruby_image
branch
7 times, most recently
from
5b436bd
to
da3cefd
Compare
|
@koic What's the status here? |
|
This is a work in progress. Just a moment, please. |
koic
force-pushed
the
use_official_jruby_image
branch
3 times, most recently
from
de46133
to
64e4b21
Compare
koic
changed the title
jruby instead of circleci/jruby images
koic
force-pushed
the
use_official_jruby_image
branch
2 times, most recently
from
4d9038d
to
bd170cf
Compare
This is an update similar to rubocop#10326. https://hub.docker.com/r/circleci/jruby hasn't been updated in a while. This PR migrates the JRuby CI matrix from CircleCI to GitHub Actions to keep up with the latest JRuby version.
koic
force-pushed
the
use_official_jruby_image
branch
from
bd170cf
to
db4fa07
Compare
|
I will merge this PR to solve #10906. Note that CodeClimate is run on MRI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update similar to #10326.
https://hub.docker.com/r/circleci/jruby hasn't been updated in a while.
This PR migrates the JRuby CI matrix from CircleCI to GitHub Actions to keep up with the latest JRuby version.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.