Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more autocorrect support on Style/EachForSimpleLoop #10928

Merged
merged 1 commit into from Aug 30, 2022

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Aug 17, 2022

If there is a block argument, it should be autocorrectable when the starting point of the range is 0.

# bad
(0...10).each do |i|
  puts i
end

# good
10.times do |i|
  puts i
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@r7kamura r7kamura force-pushed the feature/each branch 2 times, most recently from 76c1c71 to f788964 Compare August 17, 2022 02:14
@@ -28,14 +28,14 @@ class EachForSimpleLoop < Base
MSG = 'Use `Integer#times` for a simple loop which iterates a fixed number of times.'

def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
return unless offending_each_range(node)
return unless offended?(node)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think offending? is a better term here. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, thanks 😃

@koic koic merged commit 65cec7c into rubocop:master Aug 30, 2022
@koic
Copy link
Member

koic commented Aug 30, 2022

Thanks!

@r7kamura r7kamura deleted the feature/each branch August 30, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants