A bad manual correction of the Style/SafeNavigation cop isn't raised as now redundant #10926
Comments
koic
added a commit
to koic/rubocop
that referenced
this issue
Aug 17, 2022
…nil check Fixes rubocop#10926. This PR makes `Style/SafeNavigation` aware of a redundant nil check. IMHO, the context of this patch is a minimal update. OTOH, a new cop like `Style/RedundantNilCheck` cop may be implemented if it is not suitable for this `Style/SafeNavigation` cop. (But I'm not sure if it's the best.)
8 tasks
bbatsov
pushed a commit
that referenced
this issue
Aug 19, 2022
Fixes #10926. This PR makes `Style/SafeNavigation` aware of a redundant nil check. IMHO, the context of this patch is a minimal update. OTOH, a new cop like `Style/RedundantNilCheck` cop may be implemented if it is not suitable for this `Style/SafeNavigation` cop. (But I'm not sure if it's the best.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This request came about due to an incorrectly formatted piece of code which followed the pattern:
This was correctly flagged up as an offence of
Style/SafeNavigation, and so was manually adjusted to:which was not flagged up any further, despite the now redundant
nilcheck.Describe the solution you'd like
I think in this situation there should be a further offence flagged up for the now redundant
nilcheck. For example:should cause a
Style/RedundantNilCheckflag (or something similar), which itself can be fixed with:Describe alternatives you've considered
Writing a custom cop for this, although I think it would make a good default.
The text was updated successfully, but these errors were encountered: