Style/RaiseArgs autocorrection removes part of code with compact style #10622
Labels
Comments
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this issue
May 11, 2022
Fixes rubocop#10622. This PR fixes a false positive for `Style/RaiseArgs` when error type class constructor with keyword arguments and message argument. The signature of `raise` is below. ```ruby raise raise(string, cause: $!) raise(exception [, string [, array]], cause: $!) ``` https://ruby-doc.org/core-3.1.0/Kernel.html#method-i-raise So rubocop#10622 would be a false positive because `raise MyError.new(data: 'mydata'), 'message'` and `raise MyError.new('message', data: 'mydata')` are incompatible.
bbatsov
pushed a commit
that referenced
this issue
May 12, 2022
Fixes #10622. This PR fixes a false positive for `Style/RaiseArgs` when error type class constructor with keyword arguments and message argument. The signature of `raise` is below. ```ruby raise raise(string, cause: $!) raise(exception [, string [, array]], cause: $!) ``` https://ruby-doc.org/core-3.1.0/Kernel.html#method-i-raise So #10622 would be a false positive because `raise MyError.new(data: 'mydata'), 'message'` and `raise MyError.new('message', data: 'mydata')` are incompatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running
rubocop -awith autocorrect enabled with following configurationon this code:
Expected behavior
Should autocorrect to
or error as not-auto correctable but violating the
cmopactstyleActual behavior
replaces the code with:
removing the
data: "mydata"parameter silentlySteps to reproduce the problem
Run
rubocop -awith the configuration and code aboveRuboCop version
The text was updated successfully, but these errors were encountered: